Conversation
✅ Deploy Preview for openpodcastapi ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
keunes
approved these changes
Mar 26, 2026
Member
There was a problem hiding this comment.
My European heart says: we should recommend using 24hr notation instead :P
| @@ -0,0 +1,8 @@ | |||
| extends: existence | |||
| message: "'%s' should be in lowercase." | |||
Member
There was a problem hiding this comment.
Why lowercase if the rule is about colons? I'm confused :-)
| @@ -0,0 +1,9 @@ | |||
| extends: existence | |||
| message: "Use 'July 31, 2016' format, not '%s'." | |||
Member
There was a problem hiding this comment.
Is there a European variant of this? (31 July 2016) :P
| @@ -0,0 +1,29 @@ | |||
| extends: capitalization | |||
| message: "'%s' should use sentence-style capitalization." | |||
Member
There was a problem hiding this comment.
Will this not trigger warnings if we use things like POST in a heading?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, we don't have any checks in place on our writing style or conventions. To make this easier, this PR adds Vale rules that can be used in any editor to validate that writing is consistent and follows best practice.